Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace the usages of synchronized with ReentrantLock #3040

Closed
krmahadevan opened this issue Jan 17, 2024 · 0 comments · Fixed by #3077
Closed

replace the usages of synchronized with ReentrantLock #3040

krmahadevan opened this issue Jan 17, 2024 · 0 comments · Fixed by #3077

Comments

@krmahadevan
Copy link
Member

Virtual Threads usage encourages the usage of locks against synchronization in order to avoid thread pinning.

TestNG as a library at some point in time would need to start adopting Virtual Threads and so we may need to incorporate a change similar to this PR in Postgres JDBC Driver pgjdbc/pgjdbc#2635

Corresponding release notes https://jdbc.postgresql.org/changelogs/2023-03-17-42.6.0-release/

krmahadevan added a commit to krmahadevan/testng that referenced this issue Feb 26, 2024
@krmahadevan krmahadevan added this to the 7.10.0 milestone Feb 26, 2024
krmahadevan added a commit that referenced this issue Mar 5, 2024
* Use Locks instead of synchronised keyword

Closes #3040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant