Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #1461: TestNG not getting garbage collected #1482

Merged
merged 3 commits into from
Jul 20, 2017

Conversation

juherr
Copy link
Member

@juherr juherr commented Jul 20, 2017

Fixes #1461.
Closes #1468

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt

All the work comes from @kiru in #1468

@cbeust cbeust merged commit 48329b6 into testng-team:master Jul 20, 2017
@juherr juherr deleted the issue-#1461 branch July 20, 2017 20:45
@ben-manes
Copy link
Contributor

You might prefer using Guava testlib's GcFinalization, which has similar but more robust GC logic. Presumably the tests can have the dependency.

@kiru
Copy link

kiru commented Jul 27, 2017

@ben-manes This is interesting, I didn't know that class, thank you. I this case, guava is missing in the test dependencies ( which is ok ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants