Fix bux where Strings.join returns empty String #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Strings.join is given a single element, an empty String is returned instead of the element.
krmahadevan
reviewed
Jan 24, 2021
| /** | ||
| * Unit tests for {@link Strings} | ||
| * | ||
| * @author Spencer Gilson |
There was a problem hiding this comment.
@sgilson - Can you please remove off the author tag ?
krmahadevan
approved these changes
Jan 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Strings.join is given an array with length of 1, it returns an empty String instead of the first element.
Did you remember to?
CHANGES.txt