Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bux where Strings.join returns empty String #2465

Merged
merged 4 commits into from
Jan 24, 2021
Merged

Fix bux where Strings.join returns empty String #2465

merged 4 commits into from
Jan 24, 2021

Conversation

sgilson
Copy link
Contributor

@sgilson sgilson commented Jan 24, 2021

When Strings.join is given an array with length of 1, it returns an empty String instead of the first element.

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt

When Strings.join is given a single element, an empty String is returned instead of the element.
/**
* Unit tests for {@link Strings}
*
* @author Spencer Gilson
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgilson - Can you please remove off the author tag ?

@krmahadevan krmahadevan added this to the 7.4.0 milestone Jan 24, 2021
@juherr juherr merged commit 378e63e into testng-team:master Jan 24, 2021
@sgilson sgilson deleted the strings-util-fix branch January 24, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants