-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2734 keep the initial order of listeners #2737
#2734 keep the initial order of listeners #2737
Conversation
@asolntsev - Thank you so much for taking the time to raise a PR. Can you please help add tests that will essentially vet out the changes for the defects that you linked? |
@krmahadevan Ugh... It was not easy, but I added the test: TestRunnerTest.java |
We need to run listeners at the same order in which they were declared in @listeners({First.class, Second.class, Third.class})
@asolntsev - There are test failures. Please help take a look and help fix them. |
@krmahadevan I have fixed the tests. I think the last CI failure is not caused by my changes. It seems to be some flaky test caused by concurrent tests run:
|
@asolntsev - Thank you so much for helping out with this PR. This now stands merged. Look forward to more such contributions |
Yes! Achievement unlocked :) |
We need to run listeners at the same order in which they were declared in @listeners({First.class, Second.class, Third.class})
Fixes #2734 and #1219
Did you remember to?
CHANGES.txt
./gradlew autostyleApply