fix possibilty that AfterGroups method is invoked before all tests #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for defined groups are invoked, in case when AfterGrouos method has multiple groups defined
krmahadevan
reviewed
Apr 25, 2022
testng-core/src/main/java/org/testng/internal/ConfigurationGroupMethods.java
Outdated
Show resolved
Hide resolved
krmahadevan
reviewed
Apr 25, 2022
krmahadevan
approved these changes
Apr 26, 2022
|
@juherr can you please help take a quick look ? |
juherr
reviewed
Apr 26, 2022
testng-core/src/main/java/org/testng/internal/ConfigurationGroupMethods.java
Show resolved
Hide resolved
juherr
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2754
When AfterGroups method has multiple groups defined then situation was possible that it is invoked not after all tests for all its groups but after the last test of any group
Did you remember to?
CHANGES.txt./gradlew autostyleApplyWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.