Fix typos #2772
Merged
Fix typos #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juherr
reviewed
Jun 2, 2022
| && currentThreadId != threadIdToRunOn) { | ||
| completed = false; | ||
| return; | ||
| } | ||
|
|
||
| for (IMethodInstance testMthdInst : m_methodInstances) { | ||
| ITestNGMethod testMethod = testMthdInst.getMethod(); | ||
| for (IMethodInstance testMethdInstance : m_methodInstances) { |
There was a problem hiding this comment.
I think you can add the last missing 'o' 😉
juherr
approved these changes
Jun 2, 2022
krmahadevan
approved these changes
Jun 2, 2022
krmahadevan
requested changes
Jun 2, 2022
There was a problem hiding this comment.
The build is failing because of formatting issues.
Can you please do the following ?
./gradlew autostyleApply(This will apply code formatting)- Commit the changes.
- Run
./gradlew clean check(This will ensure that the code formatting is checked and all the tests are run) - Push the changes after the tests have passed so that the PR gets updated.
krmahadevan
approved these changes
Jun 3, 2022
|
@asolntsev - Thanks for the PR. This now is merged. Look forward to more contributions from you |
|
@krmahadevan I see the project doesn't compile on "17, Adopt OpenJ9": Apparently, this JVM doesn't have method |
|
Or we would need to find a way to ensure that this test doesn't run on this JVM. We need to take a closer look on this. Thanks for highlighting this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just fixes some typos in TesTNG code/tests/comments.