New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability to provide custom message to assertThrows\expectThrows methods #2793

Merged

juherr merged 1 commit into testng-team:master from anatolyuzhakov:feature/add-assert-throws-overloads

Aug 30, 2022

Contributor

anatolyuzhakov commented Aug 17, 2022

overloaded Assert.assertThrows and Assert.expectThrows methods;
added tests for overloaded Assert.expectThrows method;
updated CHANGES.txt.


          - overloaded Assert.assertThrows and Assert.expectThrows methods;

4d40e64

- added tests for overloaded Assert.expectThrows method.

anatolyuzhakov requested review from juherr and krmahadevan as code owners

August 17, 2022 21:35

krmahadevan approved these changes

View reviewed changes

juherr approved these changes

View reviewed changes

testng-asserts/src/main/java/org/testng/Assert.java

                       String.format(
                           "Expected %s to be thrown, but nothing was thrown", throwableClass.getSimpleName());
-                  throw new AssertionError(message);
+                  throw new AssertionError(message != null ? message : nothingThrownMessage);

Member

juherr Aug 30, 2022

Use positive condition

juherr merged commit c72d23a into testng-team:master

anatolyuzhakov deleted the feature/add-assert-throws-overloads branch

August 30, 2022 21:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet