Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2857 xml test index in yaml suite #2859

Merged
merged 1 commit into from
Jan 3, 2023
Merged

2857 xml test index in yaml suite #2859

merged 1 commit into from
Jan 3, 2023

Conversation

sbaranov-parasoft
Copy link

Fixes #2857.

Set XmlTest indexes after loading test suite from Yaml.

Copy link
Member

@krmahadevan krmahadevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please help add a test that validates this as well ?

Copy link
Member

@juherr juherr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be good with a non regression test 👍

@sbaranov-parasoft
Copy link
Author

Yes, sure, I'll be adding a test shortly.

@krmahadevan
Copy link
Member

Yes, sure, I'll be adding a test shortly.

@sbaranov-parasoft - It would be good if you could please help add the test asap because we plan to release 7.7.1 as a bug fix release over the weekend. So if this PR gets merged, then your change also would be available for use via this bugfix release.

@sbaranov-parasoft
Copy link
Author

I might not be able to do it by the time you mentioned. More likely next week.

@juherr
Copy link
Member

juherr commented Jan 3, 2023

Hi, sorry for the delay of the review.
Could you rebase in order to make it mergeable?

@krmahadevan
Copy link
Member

Hi, sorry for the delay of the review. Could you rebase in order to make it mergeable?

@juherr - I went ahead and then rebased this branch off of master and squashed the commits as well. Once the CI runs to completion, I will go ahead and get this merged.

@krmahadevan krmahadevan merged commit f6975f2 into testng-team:master Jan 3, 2023
@krmahadevan
Copy link
Member

@sbaranov-parasoft - Thanks for taking the time to raise this PR. This is now merged.

@sbaranov-parasoft
Copy link
Author

Thank you all for your reviews.

@sbaranov-parasoft sbaranov-parasoft deleted the 2857_XmlTestIndexInYamlSuite branch January 3, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XmlTest index is not set for test suites invoked with YAML
3 participants