Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUnitReportReporter should capture the test case output at the test c… #2876

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

JamesSassano
Copy link
Contributor

Fixes #2875 - JUnitReportReporter should capture the test case output at the test case level

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt
  • Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

  • Add new features to TestNG (or)
  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.

@krmahadevan
Copy link
Member

@juherr - Please help check and share your inputs so that we can wrap this PR.

@krmahadevan
Copy link
Member

@juherr - Gentle reminder on this.


// Add the full reporter output once as a child system-out element of testsuite.
List<String> output = Reporter.getOutput();
if ((!output.isEmpty())) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: too much parentheses

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take care of fixing this. Going ahead with merging this PR @juherr

@krmahadevan krmahadevan merged commit d8e001c into testng-team:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JUnitReportReporter should capture the test case output at the test case level
3 participants