-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade snakeyaml to 2.0 #2903
Upgrade snakeyaml to 2.0 #2903
Conversation
just adding my approval, although probably counts to nothing haha but we would love this change to go out with the security fix |
@caesar-ralf this upgrade is causing compilation errors. All tests failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pls help fix the compilation errors?
Yes, I think now it is fixed. PTAL @krmahadevan . |
Most build actions are green, but some did fail. The problem is not obvious to me. I do wonder if something is flaky and if we can re-run those tests. I appreciate any quick help here. I have never used testng (yet), neither I am familiar with the codebase or build setup here. |
No worry, we have random failures in very specific environments. |
Thanks for the help @krmahadevan and @juherr ! Any chance we can have a release with those changes? |
Yes. There should be a release in a week or so. Waiting for one more in flight PR to be ready for merge. |
Includes CVE fix https://bitbucket.org/snakeyaml/snakeyaml/issues/561/cve-2022-1471-vulnerability-in for https://nvd.nist.gov/vuln/detail/CVE-2022-1471
Did you remember to?
CHANGES.txt
./gradlew autostyleApply
We encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.