-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2974: Add overrideGroupsFromCliInParentChildXml test #2975
Conversation
@dr29bart - are you also planning to add changes to fix this issue? I ask because if this PR is containing a test that will reproduce the problem then it cannot be merged since it sill start breaking the build. |
@krmahadevan unfortunately, I don't have a solution. The PR is a just sample of test case for the bug. |
@dr29bart The fix should be easy. Do you want to try a fix? You think it is a regression. Could you tell us when the behavior changed? |
The 'groups' parameter overrides any defined groups in parent and child xml files in 7.3.0 @juherr the behavior has changed in 7.4.0 with this commit:
which then affects condition in XmlSuite#getIncludedGroups:
There is XmlTest#setIncludedGroups which works with xmlGroups,I tried to use the same approach for XmlSuite#setIncludedGroups. Please let me know if there is a better way to address the issue. |
#2974: Add a test method for "Regression in -groups CLA"
Closes #2974