Remove deprecated JUnit related support in TestNG #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@juherr |
juherr
requested changes
Dec 27, 2023
krmahadevan
force-pushed
the
remove_deprecated_junit_support
branch
from
54b0732
to
d1d73ee
Compare
Took care of this as well. Once you have approved after review, I will continue to keep this PR open and rebased so that it can be merged at a later point in time (Perhaps 2nd or 3rd week of Jan). |
juherr
approved these changes
Dec 29, 2023
krmahadevan
force-pushed
the
remove_deprecated_junit_support
branch
from
d1d73ee
to
d5f26b9
Compare
juherr
approved these changes
Jan 5, 2024
| @@ -545,11 +540,6 @@ private List<XmlSuite> createCommandLineSuitesForClasses(Class[] classes) { | |||
| if (test != null) { | |||
| suiteName = defaultIfStringEmpty(test.getSuiteName(), suiteName); | |||
| testName = defaultIfStringEmpty(test.getTestName(), testName); | |||
| } else { | |||
| if (m_isMixed && JUnitTestFinder.isJUnitTest(c)) { | |||
| isJUnit = true; | |||
There was a problem hiding this comment.
isJUnit declaration should be removed too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3022
Fixes #3022 .
Did you remember to?
CHANGES.txt./gradlew autostyleApplyWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.