Remove Ant

[juherr]

Moved to https://github.com/testng-team/testng-ant

Fixes #3033.

Did you remember to?

• Add test case(s)
• Update CHANGES.txt
• Auto applied styling via ./gradlew autostyleApply

Summary by CodeRabbit

• New Features
  • Moved Ant support to a separate repository for streamlined project management.
• Bug Fixes
  • Addressed issues leading to TestResult loss, ConcurrentModificationException, and race conditions, enhancing the stability and reliability of the application.
• Chores
  • Updated version information formatting for improved clarity.
  • Removed obsolete Ant task creation and dependencies, aligning with the move of Ant support to a dedicated repository.

[coderabbitai]

Walkthrough

This update primarily focuses on removing support for Apache Ant from the project, alongside updating version information formatting and fixing various issues including TestResult loss and race conditions. The removal of Ant support involves changes across multiple files, including the movement of Ant-related code to a separate repository and adjustments in build configurations to reflect this change.

Changes

Files	Change Summary
CHANGES.txt	Updated version info, moved Ant support, fixed issues related to TestResult loss and race conditions.
settings.gradle.kts	Removed inclusion of ":testng-ant" module.
testng-bom/.../testng-bom-build.gradle.kts	Removed testngAnt dependency.
testng/.../testng-build.gradle.kts	Removed "ant" task and references to org.testng.internal.ant, adjusted dependencies.

Assessment against linked issues

Objective	Addressed	Explanation
Drop ant support (#3033)	✅

Poem

In the codebase vast and wide, 🌐
A change did come, with stride.
Ant support, once standing tall,
Now moved aside, for progress' call. 🚀
Through files and lines, the rabbit hopped,
Ensuring nothing important was dropped. 🐇💻
"Onward!" it cheered, with every commit,
Crafting the future, bit by bit. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 6393c68 and 689727e.

Files ignored due to path filters (4)

• testng-ant/src/test/resources/ant/build-reporter-config.xml is excluded by: !**/*.xml
• testng-ant/src/test/resources/ant/build-simple.xml is excluded by: !**/*.xml
• testng-core/src/test/resources/testng.xml is excluded by: !**/*.xml
• testng-core/src/test/resources/testng.yaml is excluded by: !**/*.yaml

Files selected for processing (4)

• CHANGES.txt (1 hunks)
• settings.gradle.kts (1 hunks)
• testng-bom/testng-bom-build.gradle.kts (1 hunks)
• testng/testng-build.gradle.kts (3 hunks)

Files not reviewed due to errors (1)

• TestNG_History_Log.txt (no review received)

Files skipped from review due to trivial changes (1)

• testng-bom/testng-bom-build.gradle.kts

Additional comments: 2

settings.gradle.kts (1)

• 18-23: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-30]

The removal of the ":testng-ant" module from settings.gradle.kts aligns with the PR's objective to decouple Ant support and migrate it to a separate repository. This change is straightforward and appears to be correctly implemented, ensuring that the ":testng-ant" module is no longer included in the project's build configuration.

testng/testng-build.gradle.kts (1)

• 14-19: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-55]

The changes in testng-build.gradle.kts to remove Ant-related tasks and dependencies, including the removal of the "ant" task and references to org.testng.internal.ant, are in line with the PR's objectives. These modifications are expected to simplify the build process and reduce the project's dependency on Ant, aligning with the decision to migrate Ant support to a separate repository. It's important to ensure that these changes have been thoroughly tested to confirm that they do not negatively impact the build process or other functionalities.

[krmahadevan]

Ant support, once standing tall,
Now moved aside, for progress' call. 🚀

This was truly hilarious and yet very very relevant. 😆