Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heartbleed for STARTTLS #1

Closed
drwetter opened this issue Jul 3, 2014 · 3 comments
Closed

Heartbleed for STARTTLS #1

drwetter opened this issue Jul 3, 2014 · 3 comments
Labels
enhancement help wanted
Milestone
2.5dev (2.6)

Comments

@drwetter
Copy link
Collaborator

drwetter commented Jul 3, 2014

needs to be done
drwetter added a commit that referenced this issue Feb 11, 2015
@drwetter
- NEW: check for Secure Client-Initiated Renegotiation
d98aa62 
- debugging #1: PS4 and debugme
- debugging statement tmpfile_handle where missing #2
@drwetter
Copy link
Collaborator Author

drwetter commented Jul 1, 2015

first PoC see 21119d6#diff-4f46f3dd9f33495139a2efc31fa3acd3

@drwetter drwetter added this to the 2.5dev (2.6) milestone Jul 1, 2015
@drwetter
Copy link
Collaborator Author

drwetter commented Jul 8, 2015

Implemented as EXPERIMENTAL, see eb49c37

@drwetter
Copy link
Collaborator Author

drwetter commented Jul 8, 2015

closing after thorough testing and removed the experimental status in 3d277b5

@drwetter drwetter closed this as completed Jul 8, 2015
@jpluimers jpluimers mentioned this issue Aug 15, 2015
Closed
drwetter added a commit that referenced this issue Sep 6, 2015
@drwetter
- NEW: check for Secure Client-Initiated Renegotiation
8e9b07e 
- debugging #1: PS4 and debugme
- debugging statement tmpfile_handle where missing #2
dcooper16 referenced this issue in dcooper16/testssl.sh Feb 9, 2016
@dcooper16
Detect multiple certificates cleanup
02239be 
This corrects the indentation within determine_trust() when there are multiple certificates and the output for "Chain of trust (experim.)" takes up more than one lines.

In addition, it fixes the ID field of the JSON output for entries related to the certificate. At the moment, each ID string begins with a blank space. This changes it to remove the space if there is one certificate and to add "Server Certificate #X" at the beginning of each ID if there is more than one certificate.

Perhaps there's a better way than just using, for example, "Server Certificate #1 key_size" as a way to distinguish multiple "key_size" entries in the JSON file. This is just one idea, and it can certainly be changed if those who intend to use the JSON output prefer something else.
@dcooper16 dcooper16 mentioned this issue Feb 9, 2016
Merged
torkelsson pushed a commit to torkelsson/testssl.sh that referenced this issue Mar 1, 2016
@dcooper16 @torkelsson
Detect multiple certificates cleanup
1694beb 
This corrects the indentation within determine_trust() when there are multiple certificates and the output for "Chain of trust (experim.)" takes up more than one lines.

In addition, it fixes the ID field of the JSON output for entries related to the certificate. At the moment, each ID string begins with a blank space. This changes it to remove the space if there is one certificate and to add "Server Certificate #X" at the beginning of each ID if there is more than one certificate.

Perhaps there's a better way than just using, for example, "Server Certificate testssl#1 key_size" as a way to distinguish multiple "key_size" entries in the JSON file. This is just one idea, and it can certainly be changed if those who intend to use the JSON output prefer something else.
@va-h va-h mentioned this issue Aug 15, 2016
Closed
@drwetter drwetter mentioned this issue Aug 28, 2016
Merged
@AgoraSecurity AgoraSecurity mentioned this issue Dec 13, 2016
Closed
@drwetter drwetter mentioned this issue Jan 26, 2017
Closed
@sxxs sxxs mentioned this issue Jun 26, 2017
Closed
@drwetter drwetter mentioned this issue Dec 5, 2017
Open
drwetter added a commit that referenced this issue Jan 22, 2018
@drwetter
Changing JSON objects in server defaults ATTENTION: breaking change!!
0ec5586 
    The server default run had several JSON objects which weren't, looking at just
    the ID, either clear or contained a redundant explanation in "finding". Purely
    certificate related JSON objects are now having the id "cert_<object>" like
    cert_CN or cert_SAN.

    This commit changes all this, also it avoids another colon in finding (see #830).

    Also the implicit strategy "output for the screen s followed by only one output with
    fileout" has been relaxed -- which results on more, better parsable JSON objects.

    Some example of the changes:

    Old:
    ----
    {
        "id"           : "Server Certificate #1 fingerprint",
        "severity"     : "INFO",
        "finding"      : "Fingerprints / Serial: SHA1 2940BC13ECF7DAF30B9084CC734C3B971D73B3BB / 01BFD1DC15006E0ABBA7C670FF5E1101, SHA256 30BA61012FFE7CEAAF9A148A0CB0C5C852A9C04F4B1C27DB6
    EFA9919C7F49CCF"
    }
    [..]
    {
        "id"           : "Server Certificate #2 ocsp_stapling",
        "severity"     : "OK",
        "finding"      : "OCSP stapling : offered"
    }

    New:
    ----
    {
        "id"           : "cert_key_size <cert#1>",
        "severity"     : "INFO",
        "finding"      : "Server keys 2048 bits"
    },{
        "id"           : "cert_fingerprint_SHA1 <cert#1>",
        "severity"     : "INFO",
        "finding"      : "2940BC13ECF7DAF30B9084CC734C3B971D73B3BB"
    },{
        "id"           : "cert_fingerprint_SHA256 <cert#1>",
        "severity"     : "INFO",
        "finding"      : "30BA61012FFE7CEAAF9A148A0CB0C5C852A9C04F4B1C27DB6EFA9919C7F49CCF"
    },{
        "id"           : "cert_serial <cert#1>",
        "severity"     : "INFO",
        "finding"      : "01BFD1DC15006E0ABBA7C670FF5E1101"
    }
    [..]
    {
            "id"           : "OCSP_stapling <cert#2>",
            "severity"     : "OK",
            "finding"      : "offered"
    }

    This PR also fixes the JSON output where for "OCSP must staple" the id was just
    'id"           : "OCSP must staple: ocsp_must_staple",' for multiple server
    certificates without the certificate number.

    As far as the code is concerned: $json_prefix should be a variable which is
    used for the id object.  If there was more then one certificates for a single
    host  detected, $json_postfix carries the certificate number.

    Unit tests need to be fixed -- if possible.
@steowens steowens mentioned this issue Feb 20, 2018
Closed
@anthraxx anthraxx mentioned this issue Feb 26, 2018
Closed
@dangerbacon dangerbacon mentioned this issue Mar 16, 2018
Closed
@ZillaG ZillaG mentioned this issue Mar 27, 2018
Closed
@happyc0ding happyc0ding mentioned this issue Jul 10, 2018
Open
@MrSorcus MrSorcus mentioned this issue Aug 11, 2018
Closed
@asarubbo asarubbo mentioned this issue Jan 21, 2019
Closed
@irawanhd irawanhd mentioned this issue Feb 1, 2019
Closed
@shartge shartge mentioned this issue Apr 5, 2019
Closed
@felmoltor felmoltor mentioned this issue Apr 25, 2019
Closed
@ic0ns ic0ns mentioned this issue May 23, 2019
Open
@nrathaus nrathaus mentioned this issue Jun 26, 2019
Closed
@blshkv blshkv mentioned this issue Jul 3, 2019
Closed
@virtadpt virtadpt mentioned this issue Jul 7, 2019
Closed
@nrathaus nrathaus mentioned this issue Jul 14, 2019
Closed
@aussieklutz aussieklutz mentioned this issue Jul 19, 2019
Closed
This was referenced Sep 17, 2019
Closed
Closed
@gbiagomba gbiagomba mentioned this issue Nov 20, 2019
Closed
drwetter pushed a commit that referenced this issue Jan 27, 2020
@bkimminich
Merge pull request #1 from OWASP/drwetter-patch-1
27f8c7b 
Re-add myself ...
@timsummerer timsummerer mentioned this issue Feb 2, 2020
Closed
@gabviv73 gabviv73 mentioned this issue Feb 28, 2020
Closed
@bjmgeek bjmgeek mentioned this issue Jul 7, 2020
Closed
@gord0b gord0b mentioned this issue Jul 11, 2020
Closed
@binary64 binary64 mentioned this issue Sep 24, 2020
Open
@bjmgeek bjmgeek mentioned this issue Oct 26, 2020
Closed
@DeadManINDIA DeadManINDIA mentioned this issue Jan 8, 2021
Closed
@bunter2 bunter2 mentioned this issue Feb 1, 2021
Closed
@drwetter drwetter mentioned this issue Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
2.5dev (2.6)
Development

No branches or pull requests
1 participant
@drwetter