[Feature] Allow again file name with spaces for "--add-ca" and treat them correctly

[muralito]

Before you open an issue please check which version you are running and whether it is the latest in stable / dev branch

I am running version 3.0.8 from https://testssl.sh/

Before you open an issue please whether this is a known problem by searching the issues

I couldn't find anything related to filename with spaces

Command line / docker command to reproduce

testssl.sh --add-ca /etc/pki/trust/anchors/SPACE\ IN\ NAME.crt https://server

Fatal error: CA file "/etc/pki/trust/anchors/SPACE" does not exist

Expected behavior

Accept the filename with spaces as any other filename.

Your system (please complete the following information):

• OS: openSUSE Leap 15.6
• Platform: Linux 6.4.0-150600.23.33-default x86_64
• OpenSSL + bash: Using "OpenSSL 3.1.4 24 Oct 2023 (Library: OpenSSL 3.1.4 24 Oct 2023)" [~60 ciphers]

Additional context

Renaming the CA file to a filename without spaces solves the issue, but I reported anyway because the issue could hide another problem.

[drwetter]

Hi @muralito ,
thanks! Good catch

[drwetter]

Not as easy to fix as I thought it would be

[muralito]

Not as easy to fix as I thought it would be

Don't worry. Just put a warning in the docs and don't fix it (unless is security related)...

[drwetter]

It's potentially security related (see tag), at least when people can supply this option via web interface or so -- which OTOH and IMO doesn't seem very likely.

A fix would be easy if I could remove a feature like not supplying multiple comma separated CAs. I was sitting the other night over this (bad moment anyway) and was scratching my head how to do that properly.

[drwetter]

For now I just implemented input validation which does not allow spaces in those file names. On the long run this should be improved to allow also files with spaces -- thus I am leaving this open -- but there are other priorities here.