Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client Renego] Small important fixes #2487

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

Tazmaniac
Copy link

Describe your changes

After the previous batch of testing logic fixes for client_renego tests, some smaller but important fixes for correctness.
The main one is the zero return value with server connection close case which was previously omitted in the loop.
Manually tested on 57 url with previously suspicious results with success. No regressions on 50 others.
Running at a large automated scale on clusters since last week with no problems.

  • In case of multiple IP testing, clear ERRFILE between runs
  • Zero return value with server connection close should be taken into account in the looping logic case too. Add it.
  • Break the wait loop in case of connection close for faster result.
  • Ignore "notAfter" in the wait loop for expired certificates.
  • Indentation and tab cleanup.

What is your change about?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Typo fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable:

  • For the main program: My edits contain no tabs and the indentation is five spaces
  • I've read CONTRIBUTING.md and Coding_Convention.md
  • I have tested this fix against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order) and the change to CHANGELOG.md

- In case of multiple IP testing, clear ERRFILE bettween runs
- Zero return value with server connection close should be taken into
  account in the looping logic case too. Add it.
- Break the wait loop in case of connection close for faster result.
- Ignore "notAfter" in the wait loop for expired certificates.
- Indentation and tab cleanup.

Tested on 57 url with previously suspicious results with success. No
regressions on 50 others.
@drwetter drwetter merged commit 5581499 into testssl:3.2 Apr 2, 2024
2 checks passed
@drwetter
Copy link
Collaborator

drwetter commented Apr 2, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants