Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR modifies testssl.sh so that
run_server_defaults()
prints the server's supported TLS extensions sorted by extension number rather than listing them in the order in which they were found. This simplifies comparing the results of two tests of a server using different versions of OpenSSL, as the two tests may not detect all of the extensions in the same order.In order to simplify the sorting of the extensions, this PR changes $TLS_EXTENSIONS from a string to an array. In February 2017 comments were added (925e106) saying that it would be $TLS_EXTENSIONS were an array. So, this PR addresses those comments. However, it is possible that the reason for those comments no longer apply.
What is your pull request about?
If it's a code change please check the boxes which are applicable
help()