Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support draft-connolly-tls-mlkem-key-agreement #2690

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

dcooper16
Copy link
Collaborator

Describe your changes

This PR adds support for the three code points in draft-connolly-tls-mlkem-key-agreement. I have tested it against OpenSSL 3.5.0-dev. I also tested it against a few servers that do not support the groups in this draft.

What is your pull request about?

  • Bug fix
  • Improvement
  • New feature (adds functionality)
  • Breaking change (bug fix, feature or improvement that would cause existing functionality to not work as expected)
  • Typo fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable

  • For the main program: My edits contain no tabs and the indentation is five spaces
  • I've read CONTRIBUTING.md and Coding_Convention.md
  • I have tested this fix or improvement against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order) and the change to CHANGELOG.md

This commit adds support for the three code points in draft-connolly-tls-mlkem-key-agreement.
@drwetter drwetter merged commit 830af44 into testssl:3.2 Mar 11, 2025
2 checks passed
@drwetter
Copy link
Collaborator

Cool, works on @ghen2's host!

@dcooper16 : Mind adding the last 4 PRs to CHANGELOG.md?

@dcooper16 dcooper16 deleted the mlkem branch March 11, 2025 14:42
dcooper16 added a commit to dcooper16/testssl.sh that referenced this pull request Mar 11, 2025
This commit adds information about testssl#2687, testssl#2688, and testssl#2690 to the change log.
dcooper16 added a commit to dcooper16/testssl.sh that referenced this pull request Mar 11, 2025
This commit adds information about testssl#2687, testssl#2688, and testssl#2690 to the change log.
@dcooper16 dcooper16 mentioned this pull request Mar 11, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants