Fix for hanging on model load on Windows #40
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is the fix for the issue, when integration test for "qvac-lib-infer-llamacpp-llm" on Windows hangs.
This small missprint "ro" instead of "rb" caused undefined behavior on Windows: on the second opening a model file it always got identical file ID as was used for the first open. But fclose() already called at first open, so that second descriptor had not-null but still invalid ID, so that it hanged on fseek() method to detect file size.
Sorry, string numbers are incorrect bellow, as I added many logs and they are counted in my local repo state.