Skip to content
This repository has been archived by the owner on Aug 16, 2021. It is now read-only.

Commit

Permalink
pr comments
Browse files Browse the repository at this point in the history
Signed-off-by: Liam White <liam@tetrate.io>
  • Loading branch information
liamawhite committed Aug 2, 2019
1 parent fae602b commit b1f8c49
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/binary/getenvoy/termination.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func (r *Runtime) handleTermination() {

// Forward on the SIGINT to Envoy
log.Infof("Sending Envoy process (PID=%d) SIGINT", r.cmd.Process.Pid)
_ = r.cmd.Process.Signal(syscall.SIGKILL)
_ = r.cmd.Process.Signal(syscall.SIGINT)

// TODO: tar it all up! (Liam)
}
Expand All @@ -67,7 +67,7 @@ var EnableEnvoyAdminDataCollection = func(r *Runtime) {
r.registerPreTermination(func(r *Runtime) error {
var multiErr *multierror.Error
for path, file := range adminAPIPaths {
resp, err := http.Get(fmt.Sprintf("http://0.0.0.0:15001/%v", path))
resp, err := http.Get(fmt.Sprintf("http://localhost:15001/%v", path))
if err != nil {
multiErr = multierror.Append(multiErr, err)
}
Expand Down

0 comments on commit b1f8c49

Please sign in to comment.