Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds LookupFunction in experimental/table package #1637

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Adds LookupFunction in experimental/table package #1637

merged 2 commits into from
Aug 19, 2023

Conversation

mathetake
Copy link
Member

No description provided.

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake
Copy link
Member Author

PTAL @jerbob92

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@jerbob92
Copy link
Contributor

@mathetake Looks good to me! Shall I use this branch to change my implementation to so that we can validate it? I'm also not completely sure I always know the params/return type when I'm looking up the function, so have to try that out.

@mathetake
Copy link
Member Author

Cool that sounds great! Please let me know if you have any issue

@jerbob92
Copy link
Contributor

@mathetake looks like I can't reliably know the types in all cases, it is possible to move the typeID validation somewhere else or make it optional?

@mathetake
Copy link
Member Author

genuine question then: how can you know the stack param to be passed to Call API then?

@jerbob92
Copy link
Contributor

genuine question then: how can you know the stack param to be passed to Call API then?

Yeah you're right, but it's pretty decoupled in embind since the setup of the invokers is in a completely different place from calling it, and it doesn't always know the types when it's setting up the invokers.

But I think I was able to work around it :)

@mathetake
Copy link
Member Author

cool, keep me posted !

@jerbob92
Copy link
Contributor

@mathetake Got it fully working outside the Wazero repo: https://github.com/jerbob92/wazero-emscripten-embind

So, LGTM! 👍

@mathetake
Copy link
Member Author

Awesome!

@mathetake mathetake marked this pull request as ready for review August 19, 2023 23:09
@mathetake mathetake merged commit 4709f04 into main Aug 19, 2023
@mathetake mathetake deleted the lookupexp branch August 19, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants