-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds LookupFunction in experimental/table package #1637
Conversation
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
PTAL @jerbob92 |
Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
@mathetake Looks good to me! Shall I use this branch to change my implementation to so that we can validate it? I'm also not completely sure I always know the params/return type when I'm looking up the function, so have to try that out. |
Cool that sounds great! Please let me know if you have any issue |
@mathetake looks like I can't reliably know the types in all cases, it is possible to move the typeID validation somewhere else or make it optional? |
genuine question then: how can you know the |
Yeah you're right, but it's pretty decoupled in embind since the setup of the invokers is in a completely different place from calling it, and it doesn't always know the types when it's setting up the invokers. But I think I was able to work around it :) |
cool, keep me posted ! |
@mathetake Got it fully working outside the Wazero repo: https://github.com/jerbob92/wazero-emscripten-embind So, LGTM! 👍 |
Awesome! |
No description provided.