Supports compilation with GOOS=aix #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nuno Cruces <ncruces@users.noreply.github.com>
ncruces
requested review from
codefromthecrypt and
mathetake
as code owners
|
Line 233 in 2686665 could you add test like ^^? |
|
👁️ 🐝 |
Signed-off-by: Nuno Cruces <ncruces@users.noreply.github.com>
evacchi
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through
go tool dist listongo version go1.21.1 darwin/amd64this was the only target that didn't compile.The specific issue is that on AIX
ENOTEMPTYis the same asEEXISTso they can't both be in a switch.But we decided not to fix similar issues either for
plan9in #1603.Since this is in
experimental, I think that's the correct approach.