wasi: path_open should accept a dir with RIGHT_FD_WRITE
#2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a `path_open` behavior that allows a directory to be `path_open`ed with the `rights::fd_write` flag. Since Wazero considers it to be an error to open a directory with the write flag normally, it is safe to treat this as a bug. Although rights/capability system is being scrapped, we still use the `fd_read` and `fd_write` flag to determine if write permission needs to be set. fixes tetratelabs#2243 Signed-off-by: Yage Hu <me@huyage.dev>
|
Interesting apparently this fails a test case in the zig stdlib! |
I checked out main and the Zig stdlib test is still failing. Seems unrelated? |
|
First, thanks anyway for the contribution! Now, unfortunately I checked out both this branch and make sure you first build the zig test cases, see wazero/.github/workflows/integration.yaml Line 77 in 253c034 Regardless, the PR should include a test for this case too. |
|
Ahh OK it uses the built Wazero. I just had to rebuild wazero. Now I can repro. Thanks! |
yagehu
changed the title
mathetake
changed the title
Signed-off-by: Yage Hu <me@huyage.dev>
Signed-off-by: Yage Hu <me@huyage.dev>
yagehu
commented
Jun 10, 2024
evacchi
reviewed
Jun 11, 2024
yagehu
commented
Jun 11, 2024
evacchi
approved these changes
Jun 11, 2024
evacchi
changed the title
path_open should accept a dir with RIGHT_FD_WRITE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a
path_openbehavior that allows a directory to bepath_opened with therights::fd_writeflag. Since Wazero considers it to be an error to open a directory with the write flag normally, it is safe to treat this as a bug. Although rights/capability system is being scrapped, we still use thefd_readandfd_writeflag to determine if write permission needs to be set.fixes #2243