Allow custom memory allocator Reallocate to fail #2315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋
This is just an idea, but the change was small enough that I decided to just try it.
How would we feel about allowing the custom allocator to return
nil
to signal it can't grow the linear memory?In Go, a failure to allocate memory is a fatal condition, so it makes sense that we don't think about this when using
append
to grow the linear memory.But custom allocators can handle this, it doesn't need to be a fatal condition. Also Wasm modules can deal with it: e.g. for
wasi-lib
, ifsbrk
fails,malloc
just returnsNULL
, and (e.g.) SQLite can deal with that by freeing caches and trying again (if configured to do so).cc: @anuraaga