Emit backtrace in runtime error message. #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
codefromthecrypt
approved these changes
Nov 18, 2021
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
|
@codefromthecrypt thanks for the help!! |
mathetake
changed the title
| @@ -28,4 +28,13 @@ func Test_trap(t *testing.T) { | |||
|
|
|||
| _, _, err = store.CallFunction("test", "cause_panic") | |||
| require.Error(t, err) | |||
|
|
|||
| const expErrMsg = `wasm runtime error: unreachable | |||
|
great work |
mathetake
added a commit
that referenced
this pull request
Nov 18, 2021
This commit adds the parser of the "name" custom section[1], and starts emitting the backtrace of the program into the runtime error message by leveraging the function name informations stored in "name" custom section. Note that this is the minimal implementation -- the trace doesn't contain the original Wasm instruction address nor the source code info. The former can be implemented easily but the latter requires us to implement the Wasm DWARF format parser of .debug_* custom sections[2]. [1] https://webassembly.github.io/spec/core/appendix/custom.html#name-section [2] https://yurydelendik.github.io/webassembly-dwarf/ The following is the output from examples/trap_test.go: === RUN Test_trap panic: causing panic!!!!!!!!!! wasm runtime error: unreachable wasm backtrace: 0: runtime._panic 1: main.three 2: main.two 3: main.one 4: cause_panic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the parser of the "name" custom section[1],
and starts emitting the backtrace of the program into the runtime error message
by leveraging the function name informations stored in "name" custom section.
Note that this is the minimal implementation -- the trace doesn't contain the
original Wasm instruction address nor the source code info. The former
can be implemented easily but the latter requires us to implement the Wasm
DWARF format parser of
.debug_*custom sections[2].[1] https://webassembly.github.io/spec/core/appendix/custom.html#name-section
[2] https://yurydelendik.github.io/webassembly-dwarf/
This is similar to what I did to Proxy-Wasm C++ host: proxy-wasm/proxy-wasm-cpp-host#66
The following is the output from examples/trap_test.go:
As a comparison wasmtime emits like this: