-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add helmrelease schemas 😍 #792
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwrau
requested review from
marvinWolff,
tasches and
teutonet-bot
as code owners
February 16, 2024 11:03
tasches
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it 👍
This was referenced Feb 15, 2024
I only tested this with intellij, which worked because it ignored some errors I guess and just pulled the schema for the HelmRelease from the cluster |
marvinWolff
pushed a commit
that referenced
this pull request
Mar 27, 2024
🤖 I have created a release *beep* *boop* --- ## [6.0.0](base-cluster-v5.0.1...base-cluster-v6.0.0) (2024-03-25) ### ⚠ BREAKING CHANGES * **base-cluster/kyverno:** upgrade 🤮 ([#784](#784)) ### Features * add helmrelease schemas 😍 ([#792](#792)) ([89ed7eb](89ed7eb)) * **base-cluster:** enable cilium dns proxy ([#825](#825)) ([73c97fa](73c97fa)) * **base-cluster:** upgrade all HRs and enable driftDetection ([#773](#773)) ([fe6e71a](fe6e71a)) ### Bug Fixes * **base-cluster-schema/schema:** remove required for serviceLevelAgre… ([#791](#791)) ([d9917b5](d9917b5)) * **base-cluster/grafana:** oidc secret handling ([#756](#756)) ([73a15d2](73a15d2)) * **base-cluster/kyverno:** configure missing registry for kyverno images ([#811](#811)) ([83c44f5](83c44f5)) * **base-cluster/metrics-server:** remove mount, as it's fixed via chart ([#818](#818)) ([b8cbe36](b8cbe36)) * **base-cluster/monitoring:** missing UIDs and cross-connections ([#824](#824)) ([39b19d2](39b19d2)) * **base-cluster/oauth-proxy:** use correct secretName for certificate ([#758](#758)) ([eda417c](eda417c)) * helmrelease-schemas ([#794](#794)) ([6544385](6544385)) ### Miscellaneous Chores * **base-cluster/artifacthub-images:** Update ArtifactHUB images ([#786](#786)) ([c9e14e4](c9e14e4)) * **base-cluster/backup:** pin velero, as they don't follow semver ([#781](#781)) ([a87c79e](a87c79e)) * **base-cluster/dependencies:** update docker.io/bitnami/kubectl docker tag to v1.29.3 ([#788](#788)) ([622ddd3](622ddd3)) * **base-cluster/dependencies:** update docker.io/curlimages/curl docker tag to v8.6.0 ([#753](#753)) ([ae31961](ae31961)) * **base-cluster/dependencies:** update docker.io/fluxcd/flux-cli docker tag to v2.2.3 ([#764](#764)) ([cf45276](cf45276)) * **base-cluster/dependencies:** update external-dns docker tag to v7 ([#827](#827)) ([1ea1bf9](1ea1bf9)) * **base-cluster/dependencies:** update grafana-tempo docker tag to v3 ([#828](#828)) ([7c0f9ba](7c0f9ba)) * **base-cluster/dependencies:** update helm release common to v2.16.1 ([#782](#782)) ([e6568d0](e6568d0)) * **base-cluster/dependencies:** update helm release common to v2.19.0 ([#814](#814)) ([5419c5c](5419c5c)) * **base-cluster/dependencies:** update helm release descheduler to 0.29.x ([#704](#704)) ([61264cb](61264cb)) * **base-cluster/dependencies:** update helm release kube-prometheus-stack to v57 ([#820](#820)) ([2e64dbe](2e64dbe)) * **base-cluster/dependencies:** update helm release velero to v5.4.1 ([#798](#798)) ([ab8a741](ab8a741)) * **base-cluster/dependencies:** update helm release velero to v6 ([#812](#812)) ([b09985e](b09985e)) * **base-cluster/dependencies:** update metrics-server docker tag to v7 ([#821](#821)) ([3ca7dbc](3ca7dbc)) * **base-cluster/kyverno:** upgrade 🤮 ([#784](#784)) ([1c62356](1c62356)) * **base-cluster:** streamline imagePullPolicy ([#757](#757)) ([61f1c7f](61f1c7f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Apr 22, 2024
This was referenced May 2, 2024
This was referenced Jun 18, 2024
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way we can use
# yaml-language-server: $schema=https://raw.githubusercontent.com/teutonet/teutonet-helm-charts/main/charts/base-cluster/helmrelease.schema.json
in the
cluster.yaml
s and get correct validation, completion, ...