Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ngrok_running? to re-use ngrok_process_status_lines instead of a shell process #8

Merged
merged 1 commit into from
Jan 9, 2022

Conversation

texpert
Copy link
Owner

@texpert texpert commented Jan 9, 2022

raise_if_similar_ngroks changed to work with nil pid for checking only for Ngrok process with the similar port.

spawn_new_ngrok when running with persistence will fetch the process line matching the specified Ngrok port, thus not taking into account other Ngrok processes, tunnelling on other ports.

@codeclimate
Copy link

codeclimate bot commented Jan 9, 2022

Code Climate has analyzed commit 02c4233 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.5% (8.5% change).

View more on Code Climate.

@texpert texpert merged commit 5a2ff77 into main Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant