Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set gRPC dial-options #427

Merged
merged 4 commits into from
Aug 27, 2020

Conversation

dgtony
Copy link
Contributor

@dgtony dgtony commented Aug 26, 2020

Sometimes it is very helpful to be able to set gRPC-parameters for internal communication between nodes, e.g. message size limits, gRPC interceptors etc.
And it'd be nice to have a distinct timeouts for various operations (dial/pull/push), that could be redefined by application.

Signed-off-by: Anton Dort-Golts <dortgolts@gmail.com>
Signed-off-by: Anton Dort-Golts <dortgolts@gmail.com>
Signed-off-by: Anton Dort-Golts <dortgolts@gmail.com>
Signed-off-by: Anton Dort-Golts <dortgolts@gmail.com>
Copy link
Member

@sanderpick sanderpick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for diving in 🚀

@sanderpick sanderpick merged commit ccf9eb0 into textileio:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants