Bump default autofund amount & fail fast if not enough balance for autofunding #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign
commented
Sep 23, 2020
| @@ -295,7 +295,7 @@ func setupFlags() error { | |||
| pflag.String("repopath", "~/.powergate", "Path of the repository where Powergate state will be saved.") | |||
| pflag.Bool("devnet", false, "Indicate that will be running on an ephemeral devnet. --repopath will be autocleaned on exit.") | |||
| pflag.String("ipfsapiaddr", "/ip4/127.0.0.1/tcp/5001", "IPFS API endpoint multiaddress. (Optional, only needed if FFS is used)") | |||
| pflag.Int64("walletinitialfund", 4000000000000000, "FFS initial funding transaction amount in attoFIL received by --lotusmasteraddr. (if set)") | |||
| pflag.Int64("walletinitialfund", 250_000_000_000_000_000, "FFS initial funding transaction amount in attoFIL received by --lotusmasteraddr. (if set)") | |||
There was a problem hiding this comment.
Was decided to default to 0.25 FIL in SR2.
| if err != nil { | ||
| return "", fmt.Errorf("getting balance from master addr: %s", err) | ||
| } | ||
| if balance.LessThan(types.BigAdd(types.BigInt{Int: m.iAmount}, types.NewInt(feeThreshold))) { |
There was a problem hiding this comment.
Fail fast if most prob the txn will fail if we don't have enough funds. The txn is sent async since is a blocking process in the Lotus API now since has to estimate feeds and that takes time.
We still have two improvements to do here:
- Instead of using
feeThresholdas a constant, we could craft a more dynamic calculation of estimated fees. (autofunding: dynamic calculation of fee limit #610) - Think about a possibly more reliable way to send the funding txn. If for some wild reason the sent txn failed, we'd get some unwanted result of a 0 balance addr. So looks like we should have a better tracking mechanism about this... not sure though what might be a good solution apart from just retrying with some exponential backoff. (autofunding: more reliable track of funding txn #611)
asutula
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR: