Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Docker image on release publish #613

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

asutula
Copy link
Member

@asutula asutula commented Sep 23, 2020

This should work with the new draft/publish flow.

Signed-off-by: Aaron Sutula <hi@asutula.com>
@asutula asutula requested a review from jsign September 23, 2020 22:10
@asutula asutula self-assigned this Sep 23, 2020
@@ -1,9 +1,10 @@
name: Docker Image
on:
create:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you still want this @jsign. create is triggered any time someone creates a branch or tag. Seems like the most important tags are releases, and those are now covered by release: so I removed this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@jsign jsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -1,9 +1,10 @@
name: Docker Image
on:
create:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@asutula asutula merged commit 7e02838 into master Sep 23, 2020
@asutula asutula deleted the asutula/docker-release-publish-fix branch September 23, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants