Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Leak #52

Closed
azu opened this issue Jun 15, 2021 · 3 comments · Fixed by #53 or #54
Closed

Memory Leak #52

azu opened this issue Jun 15, 2021 · 3 comments · Fixed by #53 or #54
Labels
Package: webextension Type: Bug Bug or Bug fixes

Comments

@azu
Copy link
Member

azu commented Jun 15, 2021

Probably, textlint web extension will make memory leak.

textlint worker script issue?
@azu
Copy link
Member Author

azu commented Jun 15, 2021

https://github.com/textlint/editor/blob/4678a3c956e74bc3516ce339c6eaffa4b369ea32/packages/webextension/app/scripts/background/scriptWorkerSet.ts
will not delete?

@azu azu mentioned this issue Jun 19, 2021
Merged
@azu azu closed this as completed in #53 Jun 19, 2021
@azu azu reopened this Jun 19, 2021
@azu
Copy link
Member Author

azu commented Jun 19, 2021

still happen

@azu
Copy link
Member Author

azu commented Jun 19, 2021

Probably, textlint worker may cause a memory leak.
#53 introduce LRU cache, but the same worker still working.

@azu azu mentioned this issue Jun 19, 2021
Merged
@azu azu closed this as completed in #54 Jun 19, 2021
azu added a commit that referenced this issue Jun 20, 2021
@azu
fix(webextension): correct to terminate worker
8a01e6b 
fix #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Package: webextension Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
1 participant
@azu