Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox addon can not install #61

Open
massongit opened this issue Feb 27, 2022 · 5 comments
Open

Firefox addon can not install #61

massongit opened this issue Feb 27, 2022 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@massongit
Copy link
Contributor

I can not install firefox addon because https://addons.mozilla.org/ja/firefox/addon/textlint-editor/ is 404.

azu added a commit that referenced this issue Feb 28, 2022
@azu azu added the help wanted Extra attention is needed label Feb 28, 2022
@azu
Copy link
Member

azu commented Feb 28, 2022

textlint editor for Firefox was rejected by following reason.

Remotely executing code is not permitted in any form, including using Web Workers as a sandbox.

Current textlint editor require to install worker script as remtely executing code.
It is similar with Greasemonkey-like extensions, I think.
https://addons.mozilla.org/ja/firefox/addon/tampermonkey/
https://addons.mozilla.org/ja/firefox/addon/greasemonkey/
This extension show dialog before installing the worker script for avoiding malcious script.
Also, the script is exectuted in WebWorker. the worker script can not access webextension APIs/ContentScript APIs.

But, Firefox disallow to use this approch because this is remotely executing code.


If we will re-publish textlint editor, we need to bundle textlint scripts into this extension.
It means that the extension user can not install own script.
Instead of it, the extension user select rule from built-in rules.

This approch is similar with
https://chrome.google.com/webstore/detail/textlint-proofreader/hdongmdneapmhfblomidbafplpanpdmm?hl=ja
https://github.com/io-monad/textlint-chrome-extension

@massongit
Copy link
Contributor Author

If you take a long time to resolve it, I think you can remove the Firefox add-on URL from README.md .

@azu
Copy link
Member

azu commented Feb 28, 2022

Yes I did 9bff34e

@onokatio
Copy link

@azu Could you distribute firefox .xpi file as Github release instead of AMO ?

@azu
Copy link
Member

azu commented Dec 27, 2022

Firefox require sign to install addon. So, a signing is required.

I do not understand that Self-distribution for public is allowed in Firefox Addon Guideline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants