Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arguments in method defifinition. #136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

graceful-potato
Copy link
Contributor

@graceful-potato graceful-potato commented Oct 5, 2020

Okay, I kind of fixed #135 , but I changed some other rules that I think I shouldn't have touched. I tried not to change them and do it using repositories for specific rules, but I noticed slightly different behavior when using repositories in vscode and textmate.

Before
After

Also I added double splat operator support in parameters.

@graceful-potato
Copy link
Contributor Author

graceful-potato commented Oct 6, 2020

I can undo changes in punctuation.section.function, punctuation.section.array and punctuation.section.scope and instead create 1 more rule in main repository which will contain rules for braces, brackets and parentheses, but in this case I need help with naming.
I am not sure that this is a good scope name for braces and that this is a good name for parentheses. And also we need a scope name for brackets.

@infininight can you please take a look?

…r multiline arguments in method definition without parentheses. Add support for double splat operator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tokenization breaks on list used as default parameter
1 participant