Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature foxprogs ranges #1

Open
wants to merge 95 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
95 commits
Select commit Hold shift + click to select a range
0cbbb27
Updated to new version usfm-js (#133)
larsgson Jul 6, 2022
ff23d59
all ellipsis -> ampersand - styleguidist verified
larsgson Jul 21, 2022
486cfc6
adapted tests, styleguidist and bumped version
larsgson Aug 1, 2022
7ab724e
fixed jest tests for selections
larsgson Aug 2, 2022
b50c880
skipping all not yet updated jest tests
larsgson Aug 2, 2022
7c94ad8
publishing alpha to npm
larsgson Aug 3, 2022
5dd56b7
mock test data for future bcv tree struct
larsgson Aug 9, 2022
8d39fa7
adapted bcv tree syntax at book level
larsgson Aug 9, 2022
031c848
PoC show multiple verses in parallel scipture
superdav42 Aug 10, 2022
d693468
useBcvQuery is now working
larsgson Aug 11, 2022
3c00a84
define tests for useBcvQuery
larsgson Aug 11, 2022
ad7c5f8
added useBcvQuery example to styleguidist
larsgson Aug 12, 2022
109045a
styleguidist - cleaned useBcvQuery example code
larsgson Aug 12, 2022
332dacf
styleguidist -cleaned useBcvQuery example, part 2
larsgson Aug 12, 2022
584c46d
styleguidist -cleaned useBcvQuery example, part 3
larsgson Aug 12, 2022
57c7907
v5.2.1-beta.1
Joel-C-Johnson Aug 25, 2022
f99d11f
v5.2.1-beta.2
Joel-C-Johnson Aug 25, 2022
84aef2a
WIP - ok in styleguidist, but in tc-create
mandolyte Aug 25, 2022
2ebc7c1
v5.2.1-beta.3
Joel-C-Johnson Aug 26, 2022
6a51adf
resolved the undefined error
Joel-C-Johnson Aug 26, 2022
d92f91c
WIP correct shape of object
mandolyte Aug 26, 2022
7850fe5
WIP debugging
mandolyte Aug 26, 2022
490cd18
WIP still working on hebrew detection
mandolyte Aug 26, 2022
35ac3c6
WIP moved hebrew detection to Verse.js
mandolyte Aug 26, 2022
5ac0738
Ready to review
mandolyte Aug 26, 2022
f06222a
keep some deprecated props
larsgson Aug 29, 2022
067e52b
WIP rm console logs
mandolyte Aug 29, 2022
1a20a6c
Merge branch 'feature-cn-1151-hebrew-font-larger' of https://github.c…
Joel-C-Johnson Aug 29, 2022
75ff5d4
Merge pull request #136 from unfoldingWord/feature-cn-1151-hebrew-fon…
Joel-C-Johnson Aug 30, 2022
6b41edf
Merge remote-tracking branch 'origin/master' into bugFix-Joel-1364-fi…
Joel-C-Johnson Aug 30, 2022
a08706d
v5.2.1-beta.5
Joel-C-Johnson Aug 30, 2022
3c006e0
Merge pull request #137 from unfoldingWord/bugFix-Joel-1364-fixQuotes
Joel-C-Johnson Aug 30, 2022
ef3a1b7
verses ranges now verified to work
larsgson Aug 30, 2022
a0b06ba
published npm 5.2.3-alpha
larsgson Aug 30, 2022
3fec3e5
parallel-scripture helpers conflict resolved
larsgson Aug 31, 2022
7b7c5b8
cleaned up "prettier tool" unneeded changes
larsgson Aug 31, 2022
7ee49e6
more "prettier tool" clean-up
larsgson Aug 31, 2022
fea0c32
adapted useBcvQuery props
larsgson Sep 7, 2022
222c03a
add test
mandolyte Sep 12, 2022
3feabd8
add styling for ezra
mandolyte Sep 12, 2022
c1520d0
fix dependencies
mandolyte Sep 12, 2022
1358cf3
v5.3.0-rc.11
mandolyte Sep 12, 2022
72197c0
readd code from feature branch
mandolyte Sep 12, 2022
9226a7b
v5.3.0-rc.12
mandolyte Sep 12, 2022
db28087
v5.3.0-rc.13
mandolyte Sep 12, 2022
1302685
missed commit
mandolyte Sep 13, 2022
e99f54b
merged the code
Joel-C-Johnson Sep 13, 2022
fe86b61
updated the version
Joel-C-Johnson Sep 13, 2022
6173b12
Merge pull request #140 from unfoldingWord/fix-cn-1151-add-ezra-font
Joel-C-Johnson Sep 13, 2022
d89c83f
font bugfix for ULT UST
jincypjose Sep 16, 2022
96e91a6
version update
jincypjose Sep 16, 2022
03660e2
fix version to 5.3.1-beta.0
mandolyte Sep 17, 2022
9f27708
Merge pull request #142 from unfoldingWord/Bugfix-jincy-1151
mandolyte Sep 17, 2022
940bbc4
updated the version
Joel-C-Johnson Sep 20, 2022
c0e5e2f
Merge pull request #143 from unfoldingWord/updateVersion
Joel-C-Johnson Sep 20, 2022
d51f8cb
Fix highlights by populating VerseObject if resource has new format
superdav42 Sep 26, 2022
20d0036
Merge pull request #144 from unfoldingWord/fix-highlighting-broken
superdav42 Sep 27, 2022
b8fae7e
Bump version for release
superdav42 Sep 27, 2022
3d9471b
Merge 'origin/master'
larsgson Nov 1, 2022
dae292e
Bugfix jincy 1183 (#145)
jincypjose Nov 1, 2022
c72a754
bumped version in yarn.lock
larsgson Nov 1, 2022
f6e3ad0
Merge 'origin/master'
larsgson Nov 1, 2022
ecf0bdf
bumped version
larsgson Nov 1, 2022
3f8b973
bumped version in yarn.lock
larsgson Nov 2, 2022
3dad21c
Merge 'origin/master'
larsgson Nov 14, 2022
f884cfd
Merge pull request #134 from unfoldingWord/feature-larsg-330-ampersan…
jincypjose Nov 14, 2022
da5b9d1
Merge 'origin/master'
larsgson Nov 14, 2022
eea052f
Merge 'origin/issue-718-multiple-verses-poc'
larsgson Nov 15, 2022
358cffc
styleguidist fix - in ParallelScripture.md
larsgson Nov 15, 2022
982b04c
reference ranges are now working
larsgson Nov 16, 2022
92d2783
improved reference parsing
larsgson Nov 18, 2022
a8a93e5
changed test reference in styleguidist
larsgson Nov 18, 2022
2c2a15f
prepared new structure
larsgson Nov 21, 2022
68a146d
Merge branch
larsgson Nov 21, 2022
8e5f03c
verse ranges allowed (incl. across chapters)
larsgson Nov 23, 2022
fe1567c
removed an unneeded double comment
larsgson Nov 23, 2022
f1d2258
Merge pull request #147 from unfoldingWord/feature-larsg-348-referenc…
jincypjose Nov 23, 2022
2f923fb
bumped version
larsgson Nov 23, 2022
7484355
Merge pull request #149 from unfoldingWord/larsg-update-npm-to-non-al…
jincypjose Nov 23, 2022
b42d968
Update nodejs.yml
larsgson Nov 23, 2022
462bd59
updated node and cypress
larsgson Nov 24, 2022
de69898
improved title display for multi verse ranges
larsgson Nov 24, 2022
712ba7a
Merge pull request #151 from unfoldingWord/larsg-feature-improve-titl…
jincypjose Nov 29, 2022
a3d864f
bumped version
larsgson Nov 29, 2022
a0fe0f9
Merge pull request #152 from unfoldingWord/larsg-feature-improve-titl…
jincypjose Nov 29, 2022
1919a2b
fix highlight issue
Joel-C-Johnson Dec 14, 2022
cca4f5b
v5.3.6
Joel-C-Johnson Dec 14, 2022
144403c
Merge pull request #156 from unfoldingWord/highlight-joel-1482
Joel-C-Johnson Dec 14, 2022
a0efc5d
support ranges, fix, remove unnecessary code
foxprogs Feb 2, 2023
5630285
fix tests
foxprogs Feb 2, 2023
cf2af44
update dependencies
foxprogs Feb 2, 2023
484dd54
fix test and occurence
foxprogs Feb 3, 2023
3c924a5
add node version for netlify
foxprogs Feb 6, 2023
9a285bd
fix a non-working example, remove warn in the console
foxprogs Feb 6, 2023
bb9a998
Merge branch 'master' into feature-foxprogs-ranges
foxprogs Apr 28, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: macos-latest
strategy:
matrix:
node-version: [10.15.1]
node-version: [16.14.0]
steps:
- name: Extract Branch Name
run: echo "::set-env name=BRANCH::${GITHUB_REF##*/}"
Expand Down
1 change: 1 addition & 0 deletions .node-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
16.18.1
2 changes: 1 addition & 1 deletion __tests__/fixtures/books/en_tn_65-3JN.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1,870 changes: 1,870 additions & 0 deletions __tests__/fixtures/books/ugnt_php.js

Large diffs are not rendered by default.

33 changes: 29 additions & 4 deletions __tests__/fixtures/highlighting/3jn/1-10-2.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,33 @@
module.exports = {
book: "3jn",
book: '3jn',
chapter: 1,
verse: 10,
quote: "καὶ",
quote: 'καὶ & μὴ',
occurrence: -1,
expected: [{ "text": "ἐκ", "occurrence": 1, "occurrences": 1 }, { "text": "τῆς", "occurrence": 1, "occurrences": 1 }, { "text": "ἐκκλησίας", "occurrence": 1, "occurrences": 1 }, { "text": "ἐκβάλλει", "occurrence": 1, "occurrences": 1 }]
}
expected: [
{
text: 'ἐκ',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 10 },
},
{
text: 'τῆς',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 10 },
},
{
text: 'ἐκκλησίας',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 10 },
},
{
text: 'ἐκβάλλει',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 10 },
},
],
};
39 changes: 32 additions & 7 deletions __tests__/fixtures/highlighting/3jn/1-10.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,33 @@
module.exports = {
book:"3jn",
chapter:1,
verse:10,
quote:"ἐκ τῆς ἐκκλησίας ἐκβάλλει",
occurrence:1,
expected: [{"text":"ἐκ","occurrence":1,"occurrences":1},{"text":"τῆς","occurrence":1,"occurrences":1},{"text":"ἐκκλησίας","occurrence":1,"occurrences":1},{"text":"ἐκβάλλει","occurrence":1,"occurrences":1}]
}
book: '3jn',
chapter: 1,
verse: 10,
quote: 'ἐκ τῆς ἐκκλησίας ἐκβάλλει',
occurrence: 1,
expected: [
{
text: 'ἐκ',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 10 },
},
{
text: 'τῆς',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 10 },
},
{
text: 'ἐκκλησίας',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 10 },
},
{
text: 'ἐκβάλλει',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 10 },
},
],
};
33 changes: 26 additions & 7 deletions __tests__/fixtures/highlighting/3jn/1-11-2.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,27 @@
module.exports = {
book:"3jn",
chapter:1,
verse:11,
quote:"ἀλλὰ τὸ ἀγαθόν",
occurrence:1,
expected: [{"text":"ἀλλὰ","occurrence":1,"occurrences":1},{"text":"τὸ","occurrence":2,"occurrences":2},{"text":"ἀγαθόν","occurrence":1,"occurrences":1}]
}
book: '3jn',
chapter: 1,
verse: 11,
quote: 'ἀλλὰ τὸ ἀγαθόν',
occurrence: 1,
expected: [
{
text: 'ἀλλὰ',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 11 },
},
{
text: 'τὸ',
occurrence: 2,
occurrences: 2,
reference: { chapter: 1, verse: 11 },
},
{
text: 'ἀγαθόν',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 11 },
},
],
};
39 changes: 32 additions & 7 deletions __tests__/fixtures/highlighting/3jn/1-11.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,33 @@
module.exports = {
book:"3jn",
chapter:1,
verse:11,
quote:"μὴ μιμοῦ τὸ κακὸν,",
occurrence:1,
expected: [{"text":"μὴ","occurrence":1,"occurrences":1},{"text":"μιμοῦ","occurrence":1,"occurrences":1},{"text":"τὸ","occurrence":1,"occurrences":2},{"text":"κακὸν","occurrence":1,"occurrences":1}]
}
book: '3jn',
chapter: 1,
verse: 11,
quote: 'μὴ μιμοῦ τὸ κακὸν,',
occurrence: 1,
expected: [
{
text: 'μὴ',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 11 },
},
{
text: 'μιμοῦ',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 11 },
},
{
text: 'τὸ',
occurrence: 1,
occurrences: 2,
reference: { chapter: 1, verse: 11 },
},
{
text: 'κακὸν',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 11 },
},
],
};
39 changes: 32 additions & 7 deletions __tests__/fixtures/highlighting/3jn/1-12.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,33 @@
module.exports = {
book:"3jn",
chapter:1,
verse:12,
quote:"ὑπὸ αὐτῆς τῆς ἀληθείας",
occurrence:1,
expected: [{"text":"ὑπὸ","occurrence":2,"occurrences":2},{"text":"αὐτῆς","occurrence":1,"occurrences":1},{"text":"τῆς","occurrence":1,"occurrences":1},{"text":"ἀληθείας","occurrence":1,"occurrences":1}]
}
book: '3jn',
chapter: 1,
verse: 12,
quote: 'ὑπὸ αὐτῆς τῆς ἀληθείας',
occurrence: 1,
expected: [
{
text: 'ὑπὸ',
occurrence: 2,
occurrences: 2,
reference: { chapter: 1, verse: 12 },
},
{
text: 'αὐτῆς',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 12 },
},
{
text: 'τῆς',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 12 },
},
{
text: 'ἀληθείας',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 12 },
},
],
};
33 changes: 26 additions & 7 deletions __tests__/fixtures/highlighting/3jn/1-14.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,27 @@
module.exports = {
book:"3jn",
chapter:1,
verse:14,
quote:"στόμα πρὸς στόμα",
occurrence:1,
expected: [{"text":"στόμα","occurrence":1,"occurrences":2},{"text":"πρὸς","occurrence":1,"occurrences":1},{"text":"στόμα","occurrence":2,"occurrences":2}]
}
book: '3jn',
chapter: 1,
verse: 14,
quote: 'στόμα πρὸς στόμα',
occurrence: 1,
expected: [
{
text: 'στόμα',
occurrence: 1,
occurrences: 2,
reference: { chapter: 1, verse: 14 },
},
{
text: 'πρὸς',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 14 },
},
{
text: 'στόμα',
occurrence: 2,
occurrences: 2,
reference: { chapter: 1, verse: 14 },
},
],
};
45 changes: 38 additions & 7 deletions __tests__/fixtures/highlighting/3jn/1-15.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,39 @@
module.exports = {
book:"3jn",
chapter:1,
verse:15,
quote:"ἀσπάζου τοὺς φίλους κατ’ ὄνομα",
occurrence:1,
expected: [{"text":"ἀσπάζου","occurrence":1,"occurrences":1},{"text":"τοὺς","occurrence":1,"occurrences":1},{"text":"φίλους","occurrence":1,"occurrences":1},{"text":"κατ’","occurrence":1,"occurrences":1},{"text":"ὄνομα","occurrence":1,"occurrences":1}]
}
book: '3jn',
chapter: 1,
verse: 15,
quote: 'ἀσπάζου τοὺς φίλους κατ’ ὄνομα',
occurrence: 1,
expected: [
{
text: 'ἀσπάζου',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 15 },
},
{
text: 'τοὺς',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 15 },
},
{
text: 'φίλους',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 15 },
},
{
text: 'κατ’',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 15 },
},
{
text: 'ὄνομα',
occurrence: 1,
occurrences: 1,
reference: { chapter: 1, verse: 15 },
},
],
};
33 changes: 33 additions & 0 deletions __tests__/fixtures/highlighting/php/2-1-2.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
module.exports = {
book: 'php',
chapter: 2,
verse: 1,
quote: 'εἴ…εἴ…εἴ…εἴ',
occurrence: 1,
expected: [
{
text: 'εἴ',
occurrence: 1,
occurrences: 4,
reference: { chapter: 2, verse: 1 },
},
{
text: 'εἴ',
occurrence: 2,
occurrences: 4,
reference: { chapter: 2, verse: 1 },
},
{
text: 'εἴ',
occurrence: 3,
occurrences: 4,
reference: { chapter: 2, verse: 1 },
},
{
text: 'εἴ',
occurrence: 4,
occurrences: 4,
reference: { chapter: 2, verse: 1 },
},
],
};
33 changes: 33 additions & 0 deletions __tests__/fixtures/highlighting/php/2-1-3.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
module.exports = {
book: 'php',
chapter: 2,
verse: 1,
quote: 'τις…τι…τις…τις',
occurrence: 1,
expected: [
{
text: 'τις',
occurrence: 1,
occurrences: 3,
reference: { chapter: 2, verse: 1 },
},
{
text: 'τι',
occurrence: 1,
occurrences: 1,
reference: { chapter: 2, verse: 1 },
},
{
text: 'τις',
occurrence: 2,
occurrences: 3,
reference: { chapter: 2, verse: 1 },
},
{
text: 'τις',
occurrence: 3,
occurrences: 3,
reference: { chapter: 2, verse: 1 },
},
],
};
Loading