[#257] Prevent empty transactions in transfer proposals #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinn7e
force-pushed
the
rinn7e/#257-prevent-zero-tez
branch
from
51ebaa9 to
f6d94b6
Compare
pasqu4le
suggested changes
May 25, 2021
rinn7e
force-pushed
the
rinn7e/#257-prevent-zero-tez
branch
2 times, most recently
from
801f39e to
1ead625
Compare
pasqu4le
approved these changes
May 26, 2021
Problem: Both `treasuryDAO` and `registryDAO` have proposals that can support xtz transfers. Both implement `handle_transfer` for `Xtz_transfer_type` in a way that can fail: empty transactions (of `unit` parameter an `0` amount) will be rejected by the network. Solution: Add an emptry transactions test to prove this.
Problem: Since empty transactions does now throw error as expect, we need to update baseDAO to throw this error. Solution: Update registry and treasury dao to fail proposal check when it contains empty transactions (0 mutez xtz transfer).
rinn7e
force-pushed
the
rinn7e/#257-prevent-zero-tez
branch
from
1ead625 to
77a0f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: Both
treasuryDAOandregistryDAOhave proposalsthat can support xtz transfers.
Both implement
handle_transferforXtz_transfer_typein a waythat can fail: empty transactions (of
unitparameter an0amount)will be rejected by the network.
Solution:
proposal_checknow reject proposal that containsXtz_transfer_typewith 0 mutez, add tests to cover this.Related issue(s)
Resolves #257
✅ Checklist for your Pull Request
Related changes (conditional)
silently reappearing again.
Stylistic guide (mandatory)