[#256] Allow more xtz entrypoints #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasqu4le
approved these changes
May 26, 2021
Problem: We currently have a safety check for most entrypoints to disallow xtz tokens to be mistakenly sent to the contract and allow these funds to be stuck there. We need to reconsider on which entrypoints we should keep this check and on which we don't need to (see #91). Solution: Move `accept_ownership` and `transfer_ownership` to `allowing_xtz` entrypoints.
rinn7e
force-pushed
the
rinn7e/#256-update-tez-check-entrypoints
branch
from
6a2cad8 to
b499638
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem: We currently have a safety check for most entrypoints to
disallow xtz tokens to be mistakenly sent to the contract and allow
these funds to be stuck there.
We need to reconsider on which entrypoints we should keep this check
and on which we don't need to (see #91).
Solution: Move
accept_ownershipandtransfer_ownershiptoallowing_xtzentrypoints.Related issue(s)
Resolves #256
✅ Checklist for your Pull Request
Related changes (conditional)
silently reappearing again.
Stylistic guide (mandatory)