Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing api_base_url parameter in retry_failed.py #256

Merged

Conversation

utdrmac
Copy link
Contributor

@utdrmac utdrmac commented Aug 28, 2020

Closes #253

This PR resolves the issue #253 . The following steps were performed:

  • Analysis: CLI parameters that were added in TzKT reward & block provider #232 were missing from retry_failed.py
  • Solution: Added missing parameters
  • Implementation: ^^
  • Performed tests: Tested/confirmed by end-user songproducer in issue
  • Documentation: NA
  • Check list:

[NA] I extended the Travis CI test units with the corresponding tests for this new feature (if needed).
[NA] I extended the Sphinx documentation (if needed).
[NA] I extended the help section (if needed).
[NA] I changed the README file (if needed).
[NA] I created a new issue if there is further work left to be done (if needed).

Work effort: 2hrs

@utdrmac
Copy link
Contributor Author

utdrmac commented Aug 28, 2020

ugh. crap. i committed something for another issue.

@jdsika jdsika added this to the v6.5 (Carthage) milestone Aug 28, 2020
@jdsika jdsika requested a review from amzid August 28, 2020 19:42
@jdsika jdsika added the bug Something isn't working label Aug 28, 2020
@jdsika
Copy link
Contributor

jdsika commented Aug 31, 2020

Time effort is missing + the usage of the PR template. Could you edit it please?
We need @amzid for a review before we merge.

Copy link
Contributor

@amzid amzid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to think about a better way in the future to avoid adapting retry_failed.py each time we make a change to main.py by trying somehow to merge both files or putting the common relevant parts in callable functions.

@utdrmac
Copy link
Contributor Author

utdrmac commented Sep 1, 2020

Agreed. I think we should be able to remove retry_failed.py completely and integrate another -M mode for this purpose. It's 99% the same code as main.py + everything else.

@utdrmac utdrmac merged commit 1ed4622 into tezos-reward-distributor-organization:master Sep 1, 2020
@utdrmac utdrmac deleted the issue_253 branch September 1, 2020 14:41
@jdsika
Copy link
Contributor

jdsika commented Sep 1, 2020

Please do not forget to document the work effort + contributor github name in the squash commit into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

retryfailed failed - AttributeError: 'Namespace' object has no attribute 'api_base_url'
3 participants