-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing api_base_url parameter in retry_failed.py #256
Missing api_base_url parameter in retry_failed.py #256
Conversation
ugh. crap. i committed something for another issue. |
This reverts commit c5f962e.
Time effort is missing + the usage of the PR template. Could you edit it please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to think about a better way in the future to avoid adapting retry_failed.py each time we make a change to main.py by trying somehow to merge both files or putting the common relevant parts in callable functions.
Agreed. I think we should be able to remove retry_failed.py completely and integrate another |
Please do not forget to document the work effort + contributor github name in the squash commit into master |
Closes #253
This PR resolves the issue #253 . The following steps were performed:
[NA] I extended the Travis CI test units with the corresponding tests for this new feature (if needed).
[NA] I extended the Sphinx documentation (if needed).
[NA] I extended the help section (if needed).
[NA] I changed the README file (if needed).
[NA] I created a new issue if there is further work left to be done (if needed).
Work effort: 2hrs