Add mumble registration related commands #591
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add userId as synced property, requires syncPropertyWithMapper as workaround. add register, deregister, renameRegistered methods on user.
…istered user by their name, and userRenameRegistered to rename by user id.
garrappachc
requested changes
May 28, 2024
|
Nice work! These are some useful commands :) |
garrappachc
requested changes
May 28, 2024
Removed magic number MinusOneButUnsigned Converted NoRegisteredUserError -> UserNotRegisteredError Moved getRegisteredUserWithName into client Removed syncPropertyWithMapper hack -> Mapping conversion is handled by getter/setter in User
|
What kind of tests am I missing? I'm not sure what I can test in the Other than that I think it's complete. |
|
|
Can you rebase to master or resolve merge conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
user-register,get-registered-user, anduser-rename-registeredcommands. Registration deletion is handled by sending a rename command with an undefined name. I think filteringget-registered-userhas to pull down the whole user list. Maybe it's better to just have aget-registered-listfunction instead or something.Adds
userIdas synced property. This stores the registration id.Instead of being a normal
syncProperty, a variantsyncPropertyWithMapperis used.This is a hack I'm using for now, because the murmur server will return
-1(4294967295) on successful registration deletion.-1values are mapped intoundefinedbefore syncing. I also ended up having to@ts-ignoreto make this work. There should be a better way to do this.For
userRenameRegisteredI'm not sure which packet to wait for. Currently I wait for aUserStatepacket but that might not work if the renamed user is offline.Add
register,deregister,renameRegisteredmethods on user.deregisterandrenameRegisteredare registration dependent, so the user doesn't even need to be online. It might be better to include them somewhere else.Don't merge yet, as tests are missing. Will fix after any changes. The linter is also broken on my machine.