Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chord_diagram] bugfix #17

Merged
merged 2 commits into from
Nov 25, 2020
Merged

[chord_diagram] bugfix #17

merged 2 commits into from
Nov 25, 2020

Conversation

gph82
Copy link
Contributor

@gph82 gph82 commented Nov 25, 2020

No description provided.

gph82 and others added 2 commits November 25, 2020 12:58
@gph82
Do not plot zero-width chords (#14)
5b6e627 
Co-authored-by: Guillermo Pérez-Hernández <gph82@users.noreply.github.com>
@gph82
[chord_diagram] optionally hide zero-width chords
fc78fee
@gph82
Copy link
Contributor Author

gph82 commented Nov 25, 2020

I had two commit lists ("zeroes" and "colors") and this one shoud've not have been in "zeroes" and got committed, here's the fix.

@Silmathoron Silmathoron merged commit 84d5610 into tfardet:master Nov 25, 2020
@Silmathoron
Copy link
Collaborator

OK, all good!
Be careful, I rewrote history to avoid useless commits (since we spotted this early enough)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Silmathoron Silmathoron Silmathoron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gph82 @Silmathoron