Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve trace messages / warnings & add color #866 #889

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

tfranzel
Copy link
Owner

@tfranzel tfranzel commented Dec 8, 2022

resolves #866
supersedes #868

@HansAarneLiblik please review this alternate proposal. Also not that you can use --color on the CLI.

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 98.67% // Head: 98.79% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (aec3708) compared to base (0570b70).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
+ Coverage   98.67%   98.79%   +0.11%     
==========================================
  Files          66       68       +2     
  Lines        7726     8108     +382     
==========================================
+ Hits         7624     8010     +386     
+ Misses        102       98       -4     
Impacted Files Coverage Δ
drf_spectacular/contrib/django_filters.py 89.70% <100.00%> (ø)
drf_spectacular/drainage.py 99.20% <100.00%> (+0.23%) ⬆️
drf_spectacular/generators.py 98.01% <100.00%> (ø)
drf_spectacular/management/commands/spectacular.py 96.15% <100.00%> (+0.23%) ⬆️
drf_spectacular/openapi.py 98.42% <100.00%> (+0.85%) ⬆️
tests/test_command.py 100.00% <100.00%> (ø)
tests/test_warnings.py 100.00% <100.00%> (ø)
tests/test_fields.py 100.00% <0.00%> (ø)
drf_spectacular/__init__.py 98.30% <0.00%> (ø)
drf_spectacular/extensions.py 100.00% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tfranzel tfranzel merged commit 51e2905 into master Dec 9, 2022
@tfranzel tfranzel deleted the improved_warnings branch December 10, 2022 14:27
tfranzel added a commit that referenced this pull request Dec 16, 2022
source line is non-existent, however we do have a file to emit.
tfranzel added a commit that referenced this pull request Dec 16, 2022
CLI will run with line numbers, Schema view will not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path to view on error or warning
1 participant