Fix saving work items when impersonation is enabled #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuliov
added a commit
that referenced
this pull request
May 1, 2021
Alternative implementation to PR #236
|
I opted for a different solution when a field is reset to original value and dirty flag should be cleared. You can see it in the release/1.1 branch. |
giuliov
added a commit
that referenced
this pull request
Jun 12, 2021
* fix typos in messages * Squashed commit of the following: commit 80e7206 Author: George Roberts <groberts@moddigital.net> Date: Mon Feb 8 10:51:21 2021 -0600 Remove test log line commit bf4d89d Author: George Roberts <groberts@moddigital.net> Date: Sat Feb 6 23:26:55 2021 -0600 Remove some extraneous logging commit db994e3 Author: George Roberts <groberts@moddigital.net> Date: Sat Feb 6 23:16:06 2021 -0600 Fix tests commit c5945cd Author: George Roberts <groberts@moddigital.net> Date: Sat Feb 6 22:57:14 2021 -0600 Fix bypassrules value commit 59f338d Author: George Roberts <groberts@moddigital.net> Date: Sat Feb 6 22:54:45 2021 -0600 Support for .bypassrules directive * fixed an issue which caused removing work item links to fail * Fix ".check revision false" directive disappearing on rule upload * change log * Add tests to check more double assignment cases * Fixes #229 - double assignment and reset to original value Alternative implementation to PR #236 * Fixes spurious upgrade message noted in #225 * trigger build * Fully async Co-authored-by: Rob Osborne <rob.osborne@capita.co.uk> Co-authored-by: Alexander Omelchuk <AOK@foss.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #229
Updates
WorkItemWrapperfield assignment logic so that repeated assignments of the same fields result in correct values ofChangesandIsDirty. In particular, setting a field tonulland then to a non-null value will no longer result in emitting aRemoveoperation with a non-null value.