Avoid recompiling rules on every call #242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I started working on this PR in the weekend but I need a little more time to add some tests. |
giuliov
added a commit
that referenced
this pull request
Sep 4, 2021
* Avoid recompiling the same rule on every call * Update ScriptedRuleWrapper.cs fix compilation error * Fix IdentyRef parsing * Support "only links" filter option when adding a mapping * Added tests to #242 * changelog * dependencies updated * release log Co-authored-by: Alexander Omelchuk <AOK@foss.dk> Co-authored-by: aok-foss <50981666+aok-foss@users.noreply.github.com>
|
Included in release v1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the rule code is compiled on every execution. Apart from performance impact of the compilation, this results in process private bytes growing on every execution as the dynamically compiled assemblies are never unloaded. After a number of executions, they start failing with an OutOfMemoryException.
This change does not fix the memory leak but it does make sure the rules are not recompiled unless they changed, so the leaking rate does not depend on number of rule executions.