Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail tfenv list in a virgin environment #193

Closed
wants to merge 2 commits into from

Conversation

schlueter
Copy link
Contributor

@schlueter schlueter commented Jun 24, 2020

Addresses #187

tfenv list fails if no default has been set. This should not occur.

This PR this is addressed with these improvements:

Do not fail tfenv list because tfenv version name failed, and
don't display its errors.

When tfenv list is run and no default is set, helpfully note
that and offer a remedy.

@schlueter schlueter changed the title Address https://github.com/tfutils/tfenv/issues/187 Don't fail tfenv list in a virgin environment Jun 24, 2020
@marcofranssen
Copy link

Had the same issue just today.

tfenv list will only work after you did a tfenv use. Would be great to have this fixed.

@marcofranssen
Copy link

Commenting here the following so the issue will automatically close if the PR gets merged.

resolves #187

@Zordrak
Copy link
Collaborator

Zordrak commented Feb 6, 2021

closes #182

@Zordrak
Copy link
Collaborator

Zordrak commented Feb 6, 2021

Thank you for this, I am adopting the approach, however:

Syntax doesn't quite follow standard.
Doesn't provide tests.
In constructing a test, this code fails the test as tfenv list will exit with code 1 when a default is set.

To resolve this I have create #236 based on your branch.

@Zordrak Zordrak closed this in #236 Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants