Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tfenv-min-required #235

Merged
merged 2 commits into from
Feb 6, 2021
Merged

Fix tfenv-min-required #235

merged 2 commits into from
Feb 6, 2021

Conversation

tskinn
Copy link
Contributor

@tskinn tskinn commented Feb 3, 2021

A recent PR seems to have broken min-required functionlaiy. #203 Attempting to fix here.

Example behavior seen currently (run from a terraform project directory):

$ grep -h required_version --include '*tf' "${PWD}"/* || grep -h -R required_version --include '*tf' "${PWD}"/* | grep  -o '\([0-9]\+\.\?\)\{2,3\}\(-[a-z]\+[0-9]\+\)\?'
  required_version = ">= 0.13.2"

Behavior after changes in this PR:

$ echo $(grep -h required_version --include '*tf' "${PWD}"/* || grep -h -R required_version --include '*tf' "${PWD}"/*) | grep  -o '\([0-9]\+\.\?\)\{2,3\}\(-[a-z]\+[0-9]\+\)\?'
0.13.2

@ndouglas
Copy link

ndouglas commented Feb 3, 2021

I can confirm this fixed the issue for me locally.

Copy link
Collaborator

@Zordrak Zordrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed fixes #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants