Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Vessel support - mo:bitcoin #15

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

viktorkovarik
Copy link

@viktorkovarik viktorkovarik commented Feb 14, 2023

Hi @tgalal, I want to contribute a bit to your code. Using git submodules is not very good way to go since every repository which is based on you then has to use git submodules or local copy.

I suggest that we should convert it to way, how motoko-base and others are working. It also improves importing the code since you can then use only mo:bitcoin in import path which is similar usage as mo:base has.

I've also ran tests from the Makefile on my fork and also tested it in my testing project.

Feel free to suggest changes, correct things etc.

PS: We don't need to update motoko-sha since it has working support to be used as mo:sha.

Thanks!

@viktorkovarik
Copy link
Author

Friendly reminder @tgalal @THLO @manudrijvers @BenjaminLoison

@tgalal
Copy link
Owner

tgalal commented Feb 27, 2024

@viktorkovarik Hey, I am really sorry this was completely forgotten about. I am going to look into it and get back to you this next week.

@viktorkovarik
Copy link
Author

Thanks @tgalal ! Also you can consider if you want to add your library to MOPS packages:
https://mops.one/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants