Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tgalal, I want to contribute a bit to your code. Using git submodules is not very good way to go since every repository which is based on you then has to use git submodules or local copy.
I suggest that we should convert it to way, how
motoko-base
and others are working. It also improves importing the code since you can then use onlymo:bitcoin
in import path which is similar usage asmo:base
has.I've also ran tests from the
Makefile
on my fork and also tested it in my testing project.Feel free to suggest changes, correct things etc.
PS: We don't need to update
motoko-sha
since it has working support to be used asmo:sha
.Thanks!