Get rid of the boxed iterator returned from query in favor of impl Iterator #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=======================================
Coverage 97.99% 98.00%
=======================================
Files 48 48
Lines 1948 1954 +6
=======================================
+ Hits 1909 1915 +6
Misses 39 39 ☔ View full report in Codecov by Sentry. |
tgecho
force-pushed
the
impl-iterator
branch
from
a8d21d9
to
48dda87
Compare
tgecho
force-pushed
the
impl-iterator
branch
from
026575b
to
eb000a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have a nice little performance boost, but it's currently not stable. See rust-lang/rust#91611