More chat style updates - new announcement colors, admin announcement changes, and more #16087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
Sound
TiviPlus
approved these changes
Jun 18, 2024
TiviPlus
added
the
Test Merge Candidate
comfyorange
added a commit
that referenced
this pull request
Jun 19, 2024
|
It would be better if we had different sounds tbh. This pr and the previous announcement pr both use admin sounds for not admin stuff, which is quite inconvenient for being an admeme. |
comfyorange
added a commit
that referenced
this pull request
Jun 20, 2024
|
The sound used for admin announcements is the admin ping sound which is uh, not good at all for admins. |
light mode examine blocks have the same margin as dark mode game modes use ooc announcements !!!! some stack examine fixes: no more "It is a small item.blah blah blah" all on the same line
tgstation-server
removed
the
Test Merge Candidate
comfyorange
added a commit
that referenced
this pull request
Jun 20, 2024
comfyorange
added a commit
that referenced
this pull request
Jun 20, 2024
comfyorange
added a commit
that referenced
this pull request
Jun 21, 2024
comfyorange
added a commit
that referenced
this pull request
Jun 21, 2024
comfyorange
added a commit
that referenced
this pull request
Jun 21, 2024
… they can't be confused with admeme shenanigans
comfyorange
added a commit
that referenced
this pull request
Jun 22, 2024
comfyorange
added a commit
that referenced
this pull request
Jun 22, 2024
comfyorange
added a commit
that referenced
this pull request
Jun 22, 2024
comfyorange
added a commit
that referenced
this pull request
Jun 23, 2024
comfyorange
added a commit
that referenced
this pull request
Jun 25, 2024
Lumipharon
requested changes
Jun 25, 2024
There was a problem hiding this comment.
I'm not entirely happy with these in campaign. The mission end ones in particular are... not particular informative. The most important info is the actual outcome, and thats the smallest text at the end of the annoucement.
It also doesn't even SAY what faction won/lost now.
Lumipharon
added
the
Test Merge Candidate
comfyorange
added a commit
that referenced
this pull request
Jun 26, 2024
comfyorange
added a commit
that referenced
this pull request
Jun 26, 2024
comfyorange
added a commit
that referenced
this pull request
Jun 26, 2024
comfyorange
added a commit
that referenced
this pull request
Jun 26, 2024
comfyorange
added a commit
that referenced
this pull request
Jun 27, 2024
tgstation-server
removed
the
Test Merge Candidate
comfyorange
added a commit
that referenced
this pull request
Jun 27, 2024
comfyorange
added a commit
that referenced
this pull request
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Porting a bunch of stuff from other codebases
Might be good to TM when approved so that players can
riotgive feedbackProbably the most obvious change: new examine block style (from Nova Sector)
Replaces neon announcement colors, most of them are less saturated (from Nova Sector)
OOC announcements are much more obvious (from TG)
Helpful stuff is colored green (from TG)
Other stuff:
Light mode:
Why It's Good For The Game
I think all of these are pretty replacements for the current styles. Announcement colors especially. We should at least give these a try on live through a TM to see what everyone else thinks
Changelog
🆑
add: Replaced neon announcement colors with less saturated ones
add: Helpful stuff, like using gauze or pills, has a green span in chat
add: Admin announcements play sound and look more obvious
add: Custom Information plays sound
add: New examine block style
add: Campaign missions and gamemodes use large red announcement blocks
/:cl: