Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SG minigun fixes #10209

Merged
merged 2 commits into from
May 15, 2022
Merged

SG minigun fixes #10209

merged 2 commits into from
May 15, 2022

Conversation

Arctrooper8
Copy link
Contributor

About The Pull Request

Addresses some of the issues of the SG minigun:
It now uses the normal minigun sound (it doesn't cause tinnitus anymore)
And fixed a misdesignation error in the SG vendor.

Why It's Good For The Game

People say the sound is a bit much, I have to agree.
Names matching their gun is good.

Changelog

🆑
fix: SG vendor now displays the proper name for the SG minigun
soundadd: SG minigun now uses default minigun sound, ears of the world rejoice!
sounddel: Removed minigun_sg since it is now unused and hurts everyone's ears
/:cl:

@tgstation-server tgstation-server added Fix Fixes an issue with the game. Removal Feature removal due to maintainibility or design direction. Sound Sound change. labels May 14, 2022
@TiviPlus
Copy link
Member

Why didnt you just turn it down

@Arctrooper8
Copy link
Contributor Author

Because the minigun sound is better, even MJP said so

@TiviPlus TiviPlus merged commit 9bba2fd into tgstation:master May 15, 2022
@Arctrooper8 Arctrooper8 deleted the minigun_fixes branch May 15, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fixes an issue with the game. Removal Feature removal due to maintainibility or design direction. Sound Sound change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants