Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TGUI Hive Status #10273

Closed
wants to merge 72 commits into from
Closed

TGUI Hive Status #10273

wants to merge 72 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 22, 2022

About The Pull Request

Hive status page is now rendered in a TGUI element.

Massive restructuring of queen abilities to be fully integrated with new TGUI page and actions.

Noted Issues

Why It's Good For The Game

Samples below may not reflect the current or full development of the hive status page.

image
image

Changelog

🆑
add: Xeno hive status is now a constantly updating TGUI page.
add: Xeno hivemind players can now select a xeno to jump to using the hive status UI overwatch button.
add: Evolving now closes all UI pages open.
add: Xeno purchased primordial tiers now display as a green [PRIMORDIAL] next to the tier population in the hive status UI.
imageadd: Ported CM hive status SSD icon.
qol: Evolution is displayed and can now be accessed through the hive status UI.
qol: Xeno overwatch selection now done through hive status UI. Action button no longer visible.
qol: Xeno overwatch can now be canceled without having to move by selecting the same xeno to overwatch again.
qol: Queen leadership toggle now done through hive status UI. Action button no longer visible.
qol: Queen transfer plasma now possible through hive status UI.
qol: Xeno minimap icons now display next to corresponding xeno names in hive status UI.
qol: Xeno collapse timers now display in hive status UI instead of game tab.
qol: Hive status UI can sort xeno lists by clicking on the column headers. Sorting is done by xeno tier, health points, plasma remaining, and location by alphabetical order to the first 5 letters.
fix: Queen transfer plasma message now only visible to xenos.
fix: Ghost orbiting code now properly returns an accurate reference to the atom it is orbiting.
refactor: Hive upgrades purchasing UI relocated to separate datum.
refactor: Distress mode collapse timers are now a define.
del: Old HTML hive status page now lives at your grandparents' farm upstate.
del: Queen order, the unused direct to xeno version, has been removed.
del: Removed a vestigial time check that checked if a distress beacon could be launched at 10 minutes into a round. Xenos can not hijack before 30 minutes into a round.
/:cl:

@tgstation-server tgstation-server added Feature New interesting mechanics with new interesting bugs Sprites Changes to .dmi file. UI We make things worse, but rounder labels May 22, 2022
@novaepee
Copy link
Contributor

👻

@Al-1ce
Copy link
Contributor

Al-1ce commented May 23, 2022

Looks nice. Caste icons could use a little more distinction though.

@Wayland-Smithy
Copy link
Contributor

Looks nice. Caste icons could use a little more distinction though.

wysi :trollface:

@Al-1ce
Copy link
Contributor

Al-1ce commented May 23, 2022

wysi

It's hardly 8x8 pixels. I just think the distinction between these two is very vague and not exactly helpful at a glance.
image

@ghost
Copy link
Author

ghost commented May 23, 2022

It's in fact 14x14 pixels, same size as they're displayed on the minimap. Upscaled from the actual 7x7 pixel minimap icons.

At a glance, you should be using the wiki listing instead which are full size 300x300 pixel images.

@Wayland-Smithy
Copy link
Contributor

@Al-1ce do you mean like the rows are too tight? Maybe some nth-child(odd) styling could help?

@BraveMole BraveMole added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label May 28, 2022
@Al-1ce
Copy link
Contributor

Al-1ce commented May 28, 2022

image
In testing, the middle part really doesn't look that good. It's much easier to comb through the old straight list than it is to look at every section for their respective number. If the hive population tab was converted to how it was previously listed, while keeping the general information & xenomorph list I feel like this would be good.

@Wayland-Smithy
Copy link
Contributor

I wonder if just left justifying it would help. Plus don't forget about the "show empty" toggle to reduce clutter.

@ghost
Copy link
Author

ghost commented May 28, 2022

Have you tried toggling off show empty? Button at top right side of hive population. Also is cached for xenos so you dont need to keep toggling it off if you reopen. Only for xenos as caching it for ghosts as well is iffy.

Worst case, I can always just make an option to not use TGUI.

Or, if you really want, alignment options...

@Al-1ce
Copy link
Contributor

Al-1ce commented May 29, 2022

Have you tried toggling off show empty? Button at top right side of hive population. Also is cached for xenos so you dont need to keep toggling it off if you reopen. Only for xenos as caching it for ghosts as well is iffy.

This really doesn't help much. It's still in the tier alignment from low to high which isn't easy to comb through in the midst of battle. Additionally, not being able to lock the compass onto other xenomorphs/silos is really, really stupid.

@ghost
Copy link
Author

ghost commented May 29, 2022

Locking the compass to a xeno is not something I am willing to reimplement. Use the minimap and ask where they're at.

Structures perhaps. As there are no "overwatch" for structures, the watch button can instead be used as compass lock possibly.

Still up in the air right now.

@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label May 29, 2022
@ghost ghost changed the title TGUI Hive Status (Completed!) TGUI Hive Status (Under Construction) May 29, 2022
@ghost ghost changed the title TGUI Hive Status (Under Construction) TGUI Hive Status May 29, 2022
@Al-1ce
Copy link
Contributor

Al-1ce commented May 29, 2022

Locking the compass to a xeno is not something I am willing to reimplement. Use the minimap and ask where they're at.

That's just stupid. I hope you're self-aware enough to know that it is. The compass is an essential tool when it comes to navigating and helping out the team, especially as a support caste. Checking the map and asking where somebody might be is far, far less efficient.

This removal alone is something that makes the rest of this PR negligible. Not a good change in the slightest.

@ghost
Copy link
Author

ghost commented May 29, 2022

Closed until I, or someone more experienced in UI/UX design, does a pass through the central hive population pyramid.

Possibly compact it into linear lines.

@ghost ghost closed this May 29, 2022
@ghost ghost deleted the LessCursedDataPackages branch May 29, 2022 05:40
@matt81093
Copy link

That is unfortunate. I have to agree regarding the compass following. But I'm honestly not sure what the issue is regarding the visual other than maybe separating support and melee and ranged castes just by position on the top list (left to right, same tiers).

@Wayland-Smithy
Copy link
Contributor

Wayland-Smithy commented May 29, 2022

Unless Korn does I plan to resurrect this with an "simple/complex mode" button that will display the caste counts in a less visually busy and hopefully easier to parse at a glance way and with any luck figure out a smooth way to select compass targets.

Might atomize the cancel watch fix part first though.

@matt81093
Copy link

matt81093 commented May 30, 2022

@Wayland-Smithy I was actually thinking a compact toggle like you were saying might be a good move. Glad to see I wasn't the only one who came to that conclusion. Appears Korn is off the discord for now though.

I'll play with it in the mean time locally. Edit: Couple of ideas to simplify it came to mind, which should at least help in glance read-ability.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New interesting mechanics with new interesting bugs Sprites Changes to .dmi file. UI We make things worse, but rounder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants