Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw order UI #14164

Merged
merged 9 commits into from
Oct 18, 2023
Merged

Draw order UI #14164

merged 9 commits into from
Oct 18, 2023

Conversation

Xander3359
Copy link
Contributor

@Xander3359 Xander3359 commented Oct 13, 2023

About The Pull Request

Adds a new UI to game prefs, allowing you to customize your default draw order.
image

Why It's Good For The Game

Massive QOL

Changelog

🆑
qol: You can now change your default draw order in prefs.
/:cl:

@tgstation-server tgstation-server added UI We make things worse, but rounder Quality of Life Minor changes that make the game nicer to play labels Oct 13, 2023
@github-actions github-actions bot added the Merge Conflict Pull request is in a conflicted state with base branch. label Oct 13, 2023
@tgstation-server tgstation-server removed the Merge Conflict Pull request is in a conflicted state with base branch. label Oct 13, 2023
Copy link
Member

@TiviPlus TiviPlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 14, 2023
@Xander3359
Copy link
Contributor Author

Very nice

LETS FUCKING GOOOOOOOOOOOOOOOOOOO

comfyorange added a commit that referenced this pull request Oct 15, 2023
@Derrick2Electricboogaloo
Copy link
Contributor

Seems to cause problems with the quick equip hotkeys not working properly. The draw order seems to just completely bypass the key strokes completely and sends it straight to the top. For example I use F to get my boot knife, but it still draws from my armor suit storage and place it is back.

I accidentally broke it, forgot this code was needed...
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 15, 2023
Copy link
Contributor

@Lumipharon Lumipharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bruh

@Lumipharon Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 15, 2023
comfyorange added a commit that referenced this pull request Oct 15, 2023
comfyorange added a commit that referenced this pull request Oct 16, 2023
comfyorange added a commit that referenced this pull request Oct 18, 2023
comfyorange added a commit that referenced this pull request Oct 18, 2023
@Lumipharon
Copy link
Contributor

well no one is posting any issues so I assume everything is working now.

@Lumipharon Lumipharon merged commit b93e054 into tgstation:master Oct 18, 2023
6 checks passed
github-actions bot added a commit that referenced this pull request Oct 18, 2023
@Looking4bros
Copy link

well no one is posting any issues so I assume everything is working now.

i weep, be this the reason draw order does not work like it used to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Minor changes that make the game nicer to play Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. UI We make things worse, but rounder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants